Merge lp://staging/~cjwatson/isitdeployable/refactor-tasks into lp://staging/isitdeployable
Proposed by
Colin Watson
| Status: | Merged |
|---|---|
| Approved by: | Colin Watson |
| Approved revision: | 201 |
| Merge reported by: | Ubuntu One Auto Pilot |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~cjwatson/isitdeployable/refactor-tasks |
| Merge into: | lp://staging/isitdeployable |
| Prerequisite: | lp://staging/~cjwatson/isitdeployable/test-tasks |
| Diff against target: |
579 lines (+244/-112) 2 files modified
revtracker/tasks.py (+188/-96) revtracker/tests/test_tasks.py (+56/-16) |
| To merge this branch: | bzr merge lp://staging/~cjwatson/isitdeployable/refactor-tasks |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Refactor revtracker.tasks, moving all the bzrlib interactions into a LocalBranch class.
Description of the change
Refactor revtracker.tasks, moving all the bzrlib interactions into a LocalBranch class.
In order to add git support, we'll want alternative implementations of all these methods. That will be much less spaghetti if it's all at least somewhat encapsulated already. We may need to make some slight changes to the interfaces here in order to support git, but it should be pretty close.
To post a comment you must log in.
Revision history for this message
| Colin Watson (cjwatson) | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Nice refactor, I made one comment but it's about code that was there before so if it makes sense to leave as-is, it's OK.