Merge lp://staging/~cjwatson/isitdeployable/commit-message-formatting into lp://staging/isitdeployable

Proposed by Colin Watson
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 203
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: lp://staging/~cjwatson/isitdeployable/commit-message-formatting
Merge into: lp://staging/isitdeployable
Diff against target: 24 lines (+5/-1)
2 files modified
revtracker/static/scss/deploy_tracker.scss (+4/-0)
revtracker/templates/revtracker/revision_info.html (+1/-1)
To merge this branch: bzr merge lp://staging/~cjwatson/isitdeployable/commit-message-formatting
Reviewer Review Type Date Requested Status
Daniel Manrique (community) Approve
Review via email: mp+306880@code.staging.launchpad.net

Commit message

Improve rendering of multi-line commit messages.

Description of the change

Commit messages are often multi-line, especially in git, and word-wrapping the whole thing doesn't produce something very readable.

I acknowledge that this <pre class="proportional"> business is a hack: what I actually want is probably the Django linebreaks filter, but since we're currently using pybars at the moment that's not available. For now this seems to render well enough.

To post a comment you must log in.
Revision history for this message
Daniel Manrique (roadmr) wrote :

LGTM, it's reasonable (and yes, please no more clobbering linebreaks in commit messages). Down the line we do want to stop using handlebars (and pybars) but that'll come later, so for now this is OK.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches