Breezy

lp://staging/~cjwatson/brz/fastimport-fix-directory-renames

Created by Colin Watson on 2021-10-25 and last modified on 2021-10-25

Get this branch:: bzr branch lp://staging/~cjwatson/brz/fastimport-fix-directory-renames

Only Colin Watson can upload to this branch. If you are Colin Watson please log in for upload directions.

Branch merges

No branches dependent on this one.

Ready for review for merging into lp://staging/brz

Ioana Lasc (community): Approve on 2021-10-27

Breezy developers: Pending requested 2021-10-25

Related bugs

Link a bug report

Related blueprints

Branch information

Owner:: Colin Watson

Project:: Breezy

Status:: Development

Recent revisions

7542. By Colin Watson on 2021-10-25

fastimport: Fix export of directory renames.

Passing `specific_files=[change.path[0]]` to
`tree_old.iter_entries_by_dir` yields only the entry for that path,
rather than for that path and all directory entries contained by it as
the code appeared to expect. Fix this to emit the correct rename
commands for all directory entries under the path being renamed, and fix
up subsequent delete commands to match.

This fixes the export of
https://bazaar.launchpad.net/~lazr-developers/launchpadlib/trunk/revision/36.1.1,
which renames the `launchpadlib` directory to `src/launchpadlib` as well
as making various other changes. It may be relevant to
https://bugs.launchpad.net/brz/+bug/1890216 as well, although I haven't
checked and I haven't tackled the rather larger task of writing useful
tests.