Merge lp://staging/~cjwatson/aptdaemon/debconf-flush into lp://staging/aptdaemon

Proposed by Colin Watson
Status: Merged
Approved by: Michael Vogt
Approved revision: 904
Merged at revision: 904
Proposed branch: lp://staging/~cjwatson/aptdaemon/debconf-flush
Merge into: lp://staging/aptdaemon
Diff against target: 11 lines (+1/-0)
1 file modified
aptdaemon/debconf.py (+1/-0)
To merge this branch: bzr merge lp://staging/~cjwatson/aptdaemon/debconf-flush
Reviewer Review Type Date Requested Status
Michael Vogt (community) Approve
Review via email: mp+156545@code.staging.launchpad.net

Commit message

Flush debconf-communicate stdin after writing to it.

Description of the change

When using a socket to communicate with debconf, aptdaemon's debconf proxy forwards debconf commands by writing them to debconf-communicate's stdin, but doesn't flush stdio buffers so the data can end up sitting there forever and blocking the entire transaction. See bug 1163142 and bug 1163163 for examples. Flush debconf-communicate stdin after writing to it to avoid this problem.

To post a comment you must log in.
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks Colin!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: