Ubuntu CI Services

Merge lp://staging/~cjohnston/ubuntu-ci-services-itself/theme into lp://staging/ubuntu-ci-services-itself

  1. theme
  2. Merge into trunk
Proposed by Chris Johnston
Status: Merged
Approved by: Ursula Junque
Approved revision: 16
Merged at revision: 15
Proposed branch: lp://staging/~cjohnston/ubuntu-ci-services-itself/theme
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 64 lines (+26/-4)
3 files modified
docs/README_DOCS (+5/-0)
docs/conf.py (+19/-4)
docs/requirements.txt (+2/-0)
To merge this branch: bzr merge lp://staging/~cjohnston/ubuntu-ci-services-itself/theme
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
Ursula Junque (community) Approve
Chris Johnston (community) Needs Resubmitting
Francis Ginther Approve
Review via email: mp+198143@code.staging.launchpad.net

Commit message

Add an Ubuntu theme to the docs

Description of the change

See it live: http://162.213.34.2/rtd2/

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

I pip installed the bootstrap theme from https://pypi.python.org/pypi/sphinx-bootstrap-theme/ to use. You might want to post a link if you have one so others can review. Looks good so far and i'll tentatively approve. Would like to know if others have a strong objection before top approving.

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

I went to the live version, I saw, I was convinced ;)

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

Hmm, 'pip installed' is slightly worrying, can those instructions be added to the README ?

lp://staging/~cjohnston/ubuntu-ci-services-itself/theme updated
16. By Chris Johnston

Add a readme for the docs

Revision history for this message
Chris Johnston (cjohnston) wrote :

Added a REAME_DOCS file for the docs.

 review resubmit

review: Needs Resubmitting
Revision history for this message
Ursula Junque (ursinha) wrote :

Looks good.

review: Approve
Revision history for this message
Vincent Ladeuil (vila) wrote :

Thanks for the README_DOCS !

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches