Merge lp://staging/~cjohnston/ubuntu-ci-services-itself/reject-bad-lists into lp://staging/ubuntu-ci-services-itself
Proposed by
Chris Johnston
| Status: | Merged |
|---|---|
| Approved by: | Chris Johnston |
| Approved revision: | 299 |
| Merged at revision: | 302 |
| Proposed branch: | lp://staging/~cjohnston/ubuntu-ci-services-itself/reject-bad-lists |
| Merge into: | lp://staging/ubuntu-ci-services-itself |
| Diff against target: |
152 lines (+73/-3) 4 files modified
cli/ci_libs/utils.py (+10/-0) cli/tests/test_cli.py (+45/-2) cli/tests/test_utils.py (+14/-1) cli/ubuntu-ci (+4/-0) |
| To merge this branch: | bzr merge lp://staging/~cjohnston/ubuntu-ci-services-itself/reject-bad-lists |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chris Johnston (community) | Approve | ||
| Andy Doan (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
Make the CLI check the formatting of -a and -r to ensure that there are no spaces
To post a comment you must log in.
Revision history for this message
| Andy Doan (doanac) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Andy Doan (doanac) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
don't want to sound like bike-shedding, but this confused me as I read. you have a function name:
21 +def is_valid_
but it returns true if it passes, and throws an exception if it fails. I think you want something like:
def assert_
the function returns nothing, but throws an exception if the list isn't correct.
My last comment is super shedding, so i'd just say ignore me. However, WRT "utils.InputError", I think just using Python's built-in exception "ValueError" might make more sense.