Merge lp://staging/~cjohnston/ubuntu-ci-services-itself/1290790 into lp://staging/ubuntu-ci-services-itself

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 358
Merged at revision: 384
Proposed branch: lp://staging/~cjohnston/ubuntu-ci-services-itself/1290790
Merge into: lp://staging/ubuntu-ci-services-itself
Diff against target: 265 lines (+83/-28)
5 files modified
webui/index.html (+1/-0)
webui/packages.html (+35/-0)
webui/status.html (+4/-2)
webui/webui.css (+7/-26)
webui/webui_packages.js (+36/-0)
To merge this branch: bzr merge lp://staging/~cjohnston/ubuntu-ci-services-itself/1290790
Reviewer Review Type Date Requested Status
Joe Talbott (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Chris Johnston (community) Needs Resubmitting
Evan (community) Needs Fixing
Andy Doan (community) Approve
Review via email: mp+210487@code.staging.launchpad.net

Commit message

Add page to WebUI with master package list

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:355
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/381/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/381/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

LGTM. I think this is a good step for phase-0

review: Approve
Revision history for this message
Evan (ev) wrote :

I have a few successful tickets, but this API call isn't returning any:

http://15.125.115.133/api/v1/binarypackage/?format=json
{"meta": {"limit": 20, "next": null, "offset": 0, "previous": null, "total_count": 0}, "objects": []}

What am I missing?

Revision history for this message
Evan (ev) wrote :

197 + } catch (e) {
198 + Y.webui.package_table.showMessage(json_error_msg);
199 + return;
200 + }

209 + failure: function (tx, r, e) {
210 + console.log("failure: ", tx, r, e);
211 + }

I'd use showMessage in both of these cases.

review: Needs Fixing
356. By Chris Johnston

Merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:356
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/404/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/404/rebuild

review: Approve (continuous-integration)
357. By Chris Johnston

Update per reviews

Revision history for this message
Joe Talbott (joetalbott) wrote :

I'd say add a showMessage() but leave the console.log for debugging when needed.

Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Resubmitting
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:357
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/407/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/407/rebuild

review: Approve (continuous-integration)
358. By Chris Johnston

Syntax issue per review

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:358
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/409/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/uci-engine-ci/409/rebuild

review: Approve (continuous-integration)
Revision history for this message
Joe Talbott (joetalbott) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches