Merge lp://staging/~cjohnston/ubuntu-ci-services-itself/1289001 into lp://staging/ubuntu-ci-services-itself
Proposed by
Chris Johnston
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Chris Johnston | ||||
| Approved revision: | 326 | ||||
| Merged at revision: | 338 | ||||
| Proposed branch: | lp://staging/~cjohnston/ubuntu-ci-services-itself/1289001 | ||||
| Merge into: | lp://staging/ubuntu-ci-services-itself | ||||
| Diff against target: |
122 lines (+29/-9) 3 files modified
ci-utils/ci_utils/data_store/__init__.py (+11/-8) ci-utils/ci_utils/tests/test_data_store.py (+17/-0) cli/ubuntu-ci (+1/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~cjohnston/ubuntu-ci-services-itself/1289001 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chris Johnston (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Francis Ginther | Approve | ||
|
Review via email:
|
|||
Commit message
Fix the filename uploads of the DS
Description of the change
There was some strange behavior noticed by the DS... I would upload files where the filename included the full file path (mostly in the case of the CLI I believe)... This also caused relative paths to not work, as uploading a file called ../../something
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Ah, I also saw this problem and just assumed I was doing it wrong and would use the absolute path. I though it strange at first to relocate _get_file_name outside the class, but I think it makes sense due to it being more of a utility method.
Approving.