Merge lp://staging/~cjohnston/ubuntu-ci-services-itself/1286331 into lp://staging/ubuntu-ci-services-itself
Proposed by
Chris Johnston
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Chris Johnston | ||||
| Approved revision: | 293 | ||||
| Merged at revision: | 296 | ||||
| Proposed branch: | lp://staging/~cjohnston/ubuntu-ci-services-itself/1286331 | ||||
| Merge into: | lp://staging/ubuntu-ci-services-itself | ||||
| Diff against target: |
19 lines (+0/-4) 1 file modified
cli/setup.py (+0/-4) |
||||
| To merge this branch: | bzr merge lp://staging/~cjohnston/ubuntu-ci-services-itself/1286331 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Chris Johnston (community) | Approve | ||
| Ursula Junque (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
CLI: Remove tests_require in order to not break ./run-tests
To post a comment you must log in.
Revision history for this message
| Ursula Junque (ursinha) wrote | # |
Revision history for this message
| Chris Johnston (cjohnston) wrote | # |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Is this the right thing to do? It seems run-tests should be able to figure out where the dependencies are, instead of us forcing the test dependencies as regular ones.