Summit

Merge lp://staging/~cjohnston/summit/remove-lp-info-url into lp://staging/summit

remove-lp-info-url
Merge into trunk

Proposed by Chris Johnston on 2013-05-09

Status:	Merged
Approved by:	Chris Johnston on 2013-05-10
Approved revision:	547
Merged at revision:	546
Proposed branch:	lp://staging/~cjohnston/summit/remove-lp-info-url
Merge into:	lp://staging/summit
Diff against target:	177 lines (+65/-19) 6 files modified summit/common/views.py (+0/-5) summit/schedule/templates/schedule/summit_info.html (+2/-1) summit/schedule/tests/summit_model.py (+47/-0) summit/schedule/tests/virtual.py (+5/-5) summit/schedule/views.py (+9/-6) summit/urls.py (+2/-2)
To merge this branch:	bzr merge lp://staging/~cjohnston/summit/remove-lp-info-url
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Joe Talbott			Approve on 2013-05-10
Chris Johnston			Needs Resubmitting on 2013-05-10
Review via email: mp+163219@code.staging.launchpad.net

Commit message

Removes Launchpad information link if there is no import_url

lp://staging/~cjohnston/summit/remove-lp-info-url updated on 2013-05-10

543. By Adnane Belmadiaf on 2013-05-09: [r=cjohnston] Removed the twitter feed due to deprecated api
544. By Chris Johnston <email address hidden> on 2013-05-10: [r=joetalbott] Removes the landing page and does an automatic redirect to the next summit
545. By Chris Johnston <email address hidden> on 2013-05-10: [r=joetalbott] Creates a page that lists all meetings for an event

Revision history for this message

Joe Talbott (joetalbott) wrote on 2013-05-10:

For L18 and L175 I'd recommend using:

lp_link = SummitSprint.objects.filter(summit=summit).exists()

L93 you can put this sort of logic in setUp() and it'll get called for all tests. Maybe not what you want but it's an option to avoid the code duplication of calling create_summit() in a bunch of places.

lp://staging/~cjohnston/summit/remove-lp-info-url updated on 2013-05-10