Merge lp://staging/~cjohnston/qa-dashboard/user-edit-profile into lp://staging/qa-dashboard

1) This looks a little shady:
216 + try:
217 + profile = UserProfile.objects.get(user=request.user)
218 + except UserProfile.DoesNotExist:
219 + profile = UserProfile(user=request.user)
Why would request.user not exist?

2) This seems too verbose:
165 - <li>Logged in as: <a href="http://launchpad.net/~{{ user.username }}">{{ user.username }}</a></li>
166 + <li>Logged in as: <strong><a href="http://launchpad.net/~{{ user.username }}">{{ user.username }}</a></strong></li>
167 + <li><a href="{% url 'edit_profile' %}">Edit profile</a>

Why not just have the logged-in link take you to your profile. ie:

  <li>Logged in as: <a href="{% url 'edit_profile' %}">{{ user.username }}</a></li>

> 1) This looks a little shady:
> 216 + try:
> 217 + profile = UserProfile.objects.get(user=request.user)
> 218 + except UserProfile.DoesNotExist:
> 219 + profile = UserProfile(user=request.user)
> Why would request.user not exist?
>

It isn't trying request.user, it's trying the UserProfile, which a user may or may not have.

> 2) This seems too verbose:
> 165 - <li>Logged in as: <a href="http://launchpad.net/~{{ user.username
> }}">{{ user.username }}</a></li>
> 166 + <li>Logged in as: <strong><a href="http://launchpad.net/~{{
> user.username }}">{{ user.username }}</a></strong></li>
> 167 + <li><a href="{% url 'edit_profile' %}">Edit profile</a>
>
> Why not just have the logged-in link take you to your profile. ie:
>
> <li>Logged in as: <a href="{% url 'edit_profile' %}">{{ user.username
> }}</a></li>

Is that obvious enough? Would people know that they can click it to change their settings?

> > 2) This seems too verbose:
> > 165 - <li>Logged in as: <a href="http://launchpad.net/~{{ user.username
> > }}">{{ user.username }}</a></li>
> > 166 + <li>Logged in as: <strong><a href="http://launchpad.net/~{{
> > user.username }}">{{ user.username }}</a></strong></li>
> > 167 + <li><a href="{% url 'edit_profile' %}">Edit profile</a>
> >
> > Why not just have the logged-in link take you to your profile. ie:
> >
> > <li>Logged in as: <a href="{% url 'edit_profile' %}">{{ user.username
> > }}</a></li>
>
> Is that obvious enough? Would people know that they can click it to change
> their settings?

Seemed so to me. Maybe we should ask a few other people though. I guess I just didn't see the point in a link that takes you to launchpad (and off our site)

PASSED: Continuous integration, rev:645
http://10.97.0.26:8080/job/dashboard-ci/210/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/210/rebuild

On Mon, Oct 21, 2013 at 08:09:21PM -0000, Andy Doan wrote:
> > > 2) This seems too verbose:
> > > 165 - <li>Logged in as: <a href="http://launchpad.net/~{{ user.username
> > > }}">{{ user.username }}</a></li>
> > > 166 + <li>Logged in as: <strong><a href="http://launchpad.net/~{{
> > > user.username }}">{{ user.username }}</a></strong></li>
> > > 167 + <li><a href="{% url 'edit_profile' %}">Edit profile</a>
> > >
> > > Why not just have the logged-in link take you to your profile. ie:
> > >
> > > <li>Logged in as: <a href="{% url 'edit_profile' %}">{{ user.username
> > > }}</a></li>
> >
> > Is that obvious enough? Would people know that they can click it to change
> > their settings?
>
> Seemed so to me. Maybe we should ask a few other people though. I guess I just didn't see the point in a link that takes you to launchpad (and off our site)

I'm +1 for staying on our site.

PASSED: Continuous integration, rev:646
http://10.97.0.26:8080/job/dashboard-ci/211/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/211/rebuild

+1 by me