Merge lp://staging/~cjohnston/qa-dashboard/error-icon into lp://staging/qa-dashboard
Proposed by
Chris Johnston
| Status: | Merged |
|---|---|
| Approved by: | Joe Talbott |
| Approved revision: | 178 |
| Merged at revision: | 171 |
| Proposed branch: | lp://staging/~cjohnston/qa-dashboard/error-icon |
| Merge into: | lp://staging/qa-dashboard |
| Diff against target: |
321 lines (+126/-31) 6 files modified
common/static/css/style.css (+80/-4) common/static/images/eng_hex.svg (+18/-0) dashboard/templates/smoke/build_overview.html (+7/-7) dashboard/templates/smoke/overview.html (+12/-12) dashboard/templates/smoke/results.html (+8/-8) dashboard/views/smoke.py (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~cjohnston/qa-dashboard/error-icon |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Joe Talbott | Approve | ||
|
Review via email:
|
|||
Commit message
Changes the way error notifications happen and does style changes.
Description of the change
* Fixes URLs in the CSS
* Makes theme changes to bring the site more in line with the guidelines
* Removes red bar on errors
* Adds red icon when there is an error but no bug reported
* Adds icon next to the smoke release you are currently viewing
* Changes the heading text on smoke overview to show what view you are on (flat/combined)
* Removes link for smoke view for the page you are currently on (flat/combined)
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good. Thanks.