Ubuntu CI Dashboard

Merge lp://staging/~cjohnston/qa-dashboard/common into lp://staging/qa-dashboard

  1. common
  2. Merge into dev
Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 142
Merge reported by: Chris Johnston
Merged at revision: not available
Proposed branch: lp://staging/~cjohnston/qa-dashboard/common
Merge into: lp://staging/qa-dashboard
Diff against target: 103 lines (+25/-17)
5 files modified
common/models.py (+3/-0)
common/tests.py (+16/-0)
common/views.py (+1/-0)
qa_dashboard/settings.py (+5/-3)
qa_dashboard/urls.py (+0/-14)
To merge this branch: bzr merge lp://staging/~cjohnston/qa-dashboard/common
Reviewer Review Type Date Requested Status
Joe Talbott Approve
Review via email: mp+134382@code.staging.launchpad.net

Description of the change

- Creates a common app
- Moves layout.html, 404.html, 500.html to common/templates/
- Moves static/ to common/
- Minor cleanup around the project
- Turns off i18n as we don't translate

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote :

This looks okay to me. I played around a bit with my local dev server and didn't see any issues. I'll merge in the morning if there are no objections.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches