Ubuntu CI Dashboard

Merge lp://staging/~cjohnston/qa-dashboard/bootspeed-views-rework into lp://staging/qa-dashboard

  1. bootspeed-views-rework
  2. Merge into dev
Proposed by Chris Johnston
Status: Superseded
Proposed branch: lp://staging/~cjohnston/qa-dashboard/bootspeed-views-rework
Merge into: lp://staging/qa-dashboard
Prerequisite: lp://staging/~joetalbott/qa-dashboard/add_agg_table
Diff against target: 1221 lines (+789/-215)
17 files modified
bootspeed/api.py (+194/-1)
bootspeed/migrations/0003_add_image_type.py (+100/-0)
bootspeed/models.py (+45/-19)
bootspeed/tables.py (+23/-0)
bootspeed/templates/bootspeed/arch_overview.html (+20/-4)
bootspeed/templates/bootspeed/dygraphs-divs.html (+0/-1)
bootspeed/templates/bootspeed/dygraphs.html (+0/-179)
bootspeed/templates/bootspeed/machine_data.html (+64/-0)
bootspeed/templates/bootspeed/machine_raw_data.html (+21/-0)
bootspeed/templates/bootspeed/nav.html (+2/-2)
bootspeed/views.py (+35/-2)
common/static/css/style.css (+81/-0)
common/static/js/graph.js (+191/-0)
common/templates/layout.html (+1/-5)
qa_dashboard/settings.py (+1/-0)
qa_dashboard/urls.py (+10/-2)
requirements.txt (+1/-0)
To merge this branch: bzr merge lp://staging/~cjohnston/qa-dashboard/bootspeed-views-rework
Reviewer Review Type Date Requested Status
Joe Talbott Approve
Review via email: mp+139096@code.staging.launchpad.net

This proposal supersedes a proposal from 2012-12-08.

This proposal has been superseded by a proposal from 2012-12-13.

Commit message

Adds bootspeed charts based on dygraphs.

Description of the change

 * Adds many different API's to get data for the bootspeed charts
 * Adds image_type to define daily or release
 * Adds bootspeed data in a table
 * Refactors some of the chart stuff
 * Cleans up some unused files/code
 * Adds table CSS to follow guidelines

To post a comment you must log in.
Revision history for this message
Joe Talbott (joetalbott) wrote : Posted in a previous version of this proposal

LGTM, thanks.

review: Approve
Revision history for this message
Joe Talbott (joetalbott) wrote : Posted in a previous version of this proposal

This looks okay to me. With the understanding that the aggregation methods will be reworked soon.

review: Approve
Revision history for this message
Joe Talbott (joetalbott) wrote :

Can we factor all that javascript in machine_data.html L:450? If we need to change something in the charts we'll have to remember to do it in every one.

All the api calls will need to include the _std entries as well. I'm not sure if this is planned for a later commit, if so that's fine.

review: Needs Information
Revision history for this message
Joe Talbott (joetalbott) wrote :

Looks good. Thanks for refactoring.

review: Approve
Revision history for this message
Chris Johnston (cjohnston) wrote :

No proposals found for merge of lp:~joetalbott/qa-dashboard/add_agg_table into lp:qa-dashboard.

Revision history for this message
Joe Talbott (joetalbott) :
review: Approve

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches