Merge lp://staging/~cjohnston/qa-dashboard/1246125 into lp://staging/qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 671
Merged at revision: 670
Proposed branch: lp://staging/~cjohnston/qa-dashboard/1246125
Merge into: lp://staging/qa-dashboard
Diff against target: 20 lines (+3/-0)
1 file modified
smokeng/dashboard.py (+3/-0)
To merge this branch: bzr merge lp://staging/~cjohnston/qa-dashboard/1246125
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Chris Johnston Needs Resubmitting
PS Jenkins bot continuous-integration Approve
Review via email: mp+193164@code.staging.launchpad.net

Commit message

Removing sf4p from kpi per ev

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:670
http://10.97.0.26:8080/job/dashboard-ci/241/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/241/rebuild

review: Approve (continuous-integration)
Revision history for this message
Andy Doan (doanac) wrote :

seems like we should use some constant like we did for KPI_RELEASES. Not sure if it should be opt-in like KPI_VARIANTS or opt-out like KPI_VARIANT_EXCLUDES

671. By Chris Johnston

Add KPI_VARIANT_EXCLUDES for excluding variants from KPI from Andy's review

Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Resubmitting
Revision history for this message
Andy Doan (doanac) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches