Ubuntu CI Dashboard

Merge lp://staging/~cjohnston/qa-dashboard/1219010 into lp://staging/qa-dashboard

  1. 1219010
  2. Merge into dev
Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 646
Merged at revision: 647
Proposed branch: lp://staging/~cjohnston/qa-dashboard/1219010
Merge into: lp://staging/qa-dashboard
Diff against target: 1086 lines (+504/-342)
12 files modified
common/static/css/grid.css (+0/-3)
common/static/css/new-style.css (+419/-0)
common/static/css/style.css (+16/-288)
common/templates/banner.html (+2/-2)
common/templates/layout.html (+42/-36)
common/templates/nav_entry.html (+2/-2)
smokeng/templates/smokeng/artifacts.html (+1/-1)
smokeng/templates/smokeng/smoke_layout.html (+0/-1)
smokeng/templates/smokeng/test_result_detail.html (+9/-3)
smokeng/templates/smokeng/test_results.html (+9/-3)
smokeng/views.py (+4/-2)
sru/templates/sru/sru_layout.html (+0/-1)
To merge this branch: bzr merge lp://staging/~cjohnston/qa-dashboard/1219010
Reviewer Review Type Date Requested Status
Joe Talbott Approve
PS Jenkins bot continuous-integration Approve
Adnane Belmadiaf (community) community Approve
Review via email: mp+192148@code.staging.launchpad.net

Commit message

Update to follow some of the new design guidelines, fixes the issue where artifacts looks horrible on smoke pages

To post a comment you must log in.
Revision history for this message
Adnane Belmadiaf (daker) wrote :

+1

review: Approve (community)
Revision history for this message
Joe Talbott (joetalbott) wrote :

This looks okay to me. Is the plan that new-style.css at some point replace style.css all together?

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:646
http://10.97.0.26:8080/job/dashboard-ci/213/
Executed test runs:

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/dashboard-ci/213/rebuild

review: Approve (continuous-integration)
lp://staging/~cjohnston/qa-dashboard/1219010 updated
646. By Chris Johnston

Update design, fix artifacts

Revision history for this message
Chris Johnston (cjohnston) wrote :

The plan is that new-style contains stuff from the new guidelines, style contains stuff that isn't updated yet... They will eventually both be replaced by ubuntu-style.css which would come from the design team. It's just a way of tracking what is new and what isn't.

Revision history for this message
Joe Talbott (joetalbott) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches