Merge lp://staging/~cjohnston/qa-dashboard/1087749 into lp://staging/qa-dashboard

Proposed by Chris Johnston
Status: Merged
Approved by: Chris Johnston
Approved revision: 442
Merged at revision: 440
Proposed branch: lp://staging/~cjohnston/qa-dashboard/1087749
Merge into: lp://staging/qa-dashboard
Diff against target: 251 lines (+92/-78)
5 files modified
smokeng/templates/smokeng/image_overview.html (+1/-1)
smokeng/templates/smokeng/overview.html (+1/-1)
sru/ (+67/-0)
sru/templates/sru/overview_kernel.html (+3/-68)
sru/ (+20/-8)
To merge this branch: bzr merge lp://staging/~cjohnston/qa-dashboard/1087749
Reviewer Review Type Date Requested Status
Andy Doan (community) Approve
Review via email:

Commit message

Seperates out data for sru results, switched to django-tables2, reduce db queries.

Description of the change


On the kernel summary page we were displaying one jenkins build with data from >1 jenkins build. Many times the builds are run more than once. The way we were displaying the data only appeared as though it ran once, but all of the counts displayed data from the multiple runs. When you clicked the link to the jenkins build, the data from jenkins didn't match the data from the dashboard.


Fixed the problem identified in the bug, also switched from using dataTables to django-tables2. With that, on the page I used for testing, I was able to get the queries down from 139 to 7.

To post a comment you must log in.
440. By Chris Johnston

Fixes invalid sru results being displayed, switches sru kernel page to django-tables2

441. By Chris Johnston

Update location of table.html in smokeng

Revision history for this message
Andy Doan (doanac) wrote :

I have a small nitpick with the view itself. There is no vertical spacing between the summary table (ie the line "Total Tests Skipped") and the results table. Would be nice to get that spacing back.

Revision history for this message
Andy Doan (doanac) wrote :

code seems fine otherwise

review: Approve
442. By Chris Johnston

Fix spacing per review

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches