Merge lp://staging/~cjohnston/loco-team-portal/event-recap into lp://staging/loco-team-portal
Proposed by
Chris Johnston
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~cjohnston/loco-team-portal/event-recap |
| Merge into: | lp://staging/loco-team-portal |
| Diff against target: |
218 lines (+195/-0) 3 files modified
loco_directory/events/migrations/0008_add_event_recap.py (+183/-0) loco_directory/events/models.py (+1/-0) loco_directory/templates/events/team_event_detail.inc.html (+11/-0) |
| To merge this branch: | bzr merge lp://staging/~cjohnston/loco-team-portal/event-recap |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Martin Owens (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Adds event recap to events pages.
To post a comment you must log in.
Unmerged revisions
- 501. By Chris Johnston
-
Adds migration script
- 500. By Chris Johnston
-
Adds event recap to event pages
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The proposed feature works and has no technical flaws.
But the design might be a problem, we have quite a bit of text with the same styles on the page and it's not clear that the page needs the information of a simple text box that a comment or something similar would be able to provide.
Can we link instead to a blog entry or photo gallery?