Snap Layer

Merge ~cjohnston/layer-snap:1882868 into ~stub/layer-snap:master

  1. Git
  2. lp:~cjohnston/layer-snap
  3. 1882868
  4. Merge into master
Proposed by Chris Johnston
Status: Needs review
Proposed branch: ~cjohnston/layer-snap:1882868
Merge into: ~stub/layer-snap:master
Diff against target: 34 lines (+2/-8)
2 files modified
config.yaml (+0/-6)
reactive/snap.py (+2/-2)
Reviewer Review Type Date Requested Status
Stuart Bishop Needs Fixing
Review via email: mp+385451@code.staging.launchpad.net

Commit message

Remove snap_proxy_url in favor of model-config settings.

To post a comment you must log in.
Revision history for this message
Stuart Bishop (stub) wrote :

This isn't going to work; we are removing the snap_proxy_url config item, not replacing it with a new snap_store_proxy_url config item. snap_store_proxy_url is Juju model configuration that should be used by Juju when provisioning our unit. When we remove the snap_proxy_url config item, we can probably also remove configure_snap_store_proxy() entirely, because it is all being handled by Juju before the charm is even installed. Which will need to be tested.

review: Needs Fixing
Reply

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: