Merge lp://staging/~cjohnston/launchpad/187013 into lp://staging/launchpad

Proposed by Chris Johnston
Status: Merged
Approved by: Henning Eggers
Approved revision: no longer in the source branch.
Merged at revision: 13162
Proposed branch: lp://staging/~cjohnston/launchpad/187013
Merge into: lp://staging/launchpad
Diff against target: 96 lines (+8/-8)
7 files modified
lib/lp/bugs/browser/bugsubscription.py (+2/-2)
lib/lp/bugs/browser/bugtarget.py (+1/-1)
lib/lp/bugs/browser/bugtask.py (+1/-1)
lib/lp/bugs/stories/bugs/xx-bug-personal-subscriptions-advanced-features.txt (+1/-1)
lib/lp/bugs/stories/bugs/xx-bug-personal-subscriptions.txt (+1/-1)
lib/lp/bugs/stories/bugtask-management/xx-subscribe-while-editing.txt (+1/-1)
lib/lp/bugs/stories/guided-filebug/xx-product-guided-filebug.txt (+1/-1)
To merge this branch: bzr merge lp://staging/~cjohnston/launchpad/187013
Reviewer Review Type Date Requested Status
Henning Eggers (community) Approve
Review via email: mp+61052@code.staging.launchpad.net

Commit message

Fixes some confusing text about bug subscriptions.

To post a comment you must log in.
Revision history for this message
Martin Pool (mbp) wrote :

Thank you so much for all these patches, Chris.

I wonder if <https://bugs.launchpad.net/launchpad/+bug/487893> would
be easy to do a similar fix for? I would love to see that link added.

Martin

Revision history for this message
Henning Eggers (henninge) wrote :

Hi Chris,
thanks for these fixes.
In bugsubscription.py I found this:
"Your subscription to this bug has been updated."
That should probably read "bug report subscription" for consistency? Are there other cases that should be adapted?
Sorry if I seem nit-picky here but I want to avoid more of these little bugs being filed in the future if we can do it right right now.

Thanks again!
Henning

review: Approve
Revision history for this message
Chris Johnston (cjohnston) wrote :

I am not seeing any more, but that's not to say there aren't.. I updated it.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.