Helipad

Merge lp://staging/~cjohnston/helipad/more-graphics-stuff into lp://staging/helipad/graphics

  1. more-graphics-stuff
  2. Merge into graphics
Proposed by Chris Johnston
Status: Superseded
Proposed branch: lp://staging/~cjohnston/helipad/more-graphics-stuff
Merge into: lp://staging/helipad/graphics
Prerequisite: lp://staging/~chris.gagnon/helipad/graphics-new-model
Diff against target: 129 lines (+40/-16)
3 files modified
management/commands/jenkins_pull_phoronix.py (+34/-16)
migrations/0001_initial.py (+4/-0)
models.py (+2/-0)
To merge this branch: bzr merge lp://staging/~cjohnston/helipad/more-graphics-stuff
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Francis Ginther Approve
Chris Johnston Needs Resubmitting
Review via email: mp+181972@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2013-08-26.

Commit message

Add manufacturer and model of gfx card for GraphicsMachines

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:25
http://s-jenkins:8080/job/helipad-graphics-ci/15/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/helipad-graphics-ci/15/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Does gfx_range refer to the 'le' or 'he' portion of the machine name? If so, I think this category is irrelevant and not worth tracking. It was originally used back in the day when we were testing unity 7 and needed a high end and low end box. Now just the mfg and chipset really matter. Also, newer machines aren't using this naming convention (i.e. 'ps-nvidia-310' or 'ps-intel-3000').

review: Needs Information
Revision history for this message
Francis Ginther (fginther) wrote :

I gave this a test drive and found that the gfx_range is the 'le', 'he' bit. I wouldn't track this as it doesn't add any factual info. Some of these 'high-end' chips are probably considered 'low-end' by today's standards.

review: Needs Fixing
Revision history for this message
Chris Johnston (cjohnston) :
review: Needs Resubmitting
Revision history for this message
Francis Ginther (fginther) wrote :

Approve!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://s-jenkins:8080/job/helipad-graphics-autolanding/5/
Executed test runs:

review: Needs Fixing (continuous-integration)
lp://staging/~cjohnston/helipad/more-graphics-stuff updated
24. By Chris Johnston

Add better support for displaying graphics data

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: