Helipad

Merge lp://staging/~cjohnston/helipad/main-nav-n-remove-code into lp://staging/helipad/ci

  1. main-nav-n-remove-code
  2. Merge into ci
Proposed by Chris Johnston
Status: Merged
Approved by: Francis Ginther
Approved revision: 19
Merged at revision: 18
Proposed branch: lp://staging/~cjohnston/helipad/main-nav-n-remove-code
Merge into: lp://staging/helipad/ci
Diff against target: 552 lines (+49/-415)
7 files modified
templates/ci/build.html (+0/-46)
templates/ci/integration_list.html (+0/-65)
templates/ci/job_list.html (+0/-96)
templates/ci/stack_detail.html (+0/-78)
urls_daily.py (+0/-1)
urls_merger.py (+0/-6)
views.py (+49/-123)
To merge this branch: bzr merge lp://staging/~cjohnston/helipad/main-nav-n-remove-code
Reviewer Review Type Date Requested Status
Francis Ginther Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+176447@code.staging.launchpad.net

Commit message

Fixes the main nav's need for RequestContext, removes dead views code

To post a comment you must log in.
lp://staging/~cjohnston/helipad/main-nav-n-remove-code updated
18. By Chris Johnston

Fix active not showing up in main-nav, removes dead code

19. By Chris Johnston

Remove missed unneeded template

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:18
http://s-jenkins:8080/job/helipad-ci-ci/32/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/helipad-ci-ci/32/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:19
http://s-jenkins:8080/job/helipad-ci-ci/33/
Executed test runs:

Click here to trigger a rebuild:
http://s-jenkins:8080/job/helipad-ci-ci/33/rebuild

review: Approve (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Looks good. The stack_detail was a useful view to collect similar projects and present them as a unit, but it's not being used. We can always pull it back out of the history if we need to reuse it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: