Juju Charms Collection
glance package

Merge lp://staging/~cjohnston/charms/trusty/glance/amqp-required into lp://staging/~openstack-charmers-archive/charms/trusty/glance/next

  1. Trusty Tahr (14.04)
  2. amqp-required
  3. Merge into next
Proposed by Chris Johnston
Status: Merged
Merged at revision: 169
Proposed branch: lp://staging/~cjohnston/charms/trusty/glance/amqp-required
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/glance/next
Diff against target: 36 lines (+15/-0)
2 files modified
README.md (+14/-0)
metadata.yaml (+1/-0)
To merge this branch: bzr merge lp://staging/~cjohnston/charms/trusty/glance/amqp-required
Reviewer Review Type Date Requested Status
Edward Hope-Morley Approve
OpenStack Charmers Pending
Chris Johnston Pending
Review via email: mp+282776@code.staging.launchpad.net

This proposal supersedes a proposal from 2015-09-15.

Commit message

Set AMQP interface to optional, provide documentation on the usage of the AMQP relation.

To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_lint_check #10126 glance-next for cjohnston mp271144
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/10126/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_unit_test #9288 glance-next for cjohnston mp271144
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/9288/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote : Posted in a previous version of this proposal

charm_amulet_test #6463 glance-next for cjohnston mp271144
    AMULET FAIL: amulet-test failed

AMULET Results (max last 2 lines):
make: *** [functional_test] Error 1
ERROR:root:Make target returned non-zero.

Full amulet test output: http://paste.ubuntu.com/12426488/
Build: http://10.245.162.77:8080/job/charm_amulet_test/6463/

Revision history for this message
Chris Johnston (cjohnston) : Posted in a previous version of this proposal
review: Needs Resubmitting
Revision history for this message
Edward Hope-Morley (hopem) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #17397 glance-next for cjohnston mp282776
    LINT OK: passed

Build: http://10.245.162.77:8080/job/charm_lint_check/17397/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #16253 glance-next for cjohnston mp282776
    UNIT OK: passed

Build: http://10.245.162.77:8080/job/charm_unit_test/16253/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #8810 glance-next for cjohnston mp282776
    AMULET OK: passed

Build: http://10.245.162.77:8080/job/charm_amulet_test/8810/

Revision history for this message
Edward Hope-Morley (hopem) wrote :

Lgtm +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches