Merge lp://staging/~cjcurran/indicator-sound/rewind-forwind into lp://staging/~indicator-applet-developers/indicator-sound/trunk_3
Proposed by
Conor Curran
| Status: | Merged | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Merged at revision: | 215 | ||||||||
| Proposed branch: | lp://staging/~cjcurran/indicator-sound/rewind-forwind | ||||||||
| Merge into: | lp://staging/~indicator-applet-developers/indicator-sound/trunk_3 | ||||||||
| Diff against target: | 0 lines | ||||||||
| To merge this branch: | bzr merge lp://staging/~cjcurran/indicator-sound/rewind-forwind | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Kalle Valo (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Patches for both bugs attached, plus some nice refactoring.
To post a comment you must log in.
Revision history for this message
| Conor Curran (cjcurran) wrote | # |
Commenting out MENUITEM_TYPE&co is a bit awkward. IMHO if they are not needed they should be completely removed. Otherwise looks good. Approved.