Unity 8

Merge lp://staging/~cimi/unity8/fix-1368778-2 into lp://staging/unity8

  1. fix-1368778-2
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Approved by: Michael Zanetti
Approved revision: 1455
Merged at revision: 1493
Proposed branch: lp://staging/~cimi/unity8/fix-1368778-2
Merge into: lp://staging/unity8
Diff against target: 44 lines (+7/-9)
2 files modified
qml/Launcher/Launcher.qml (+7/-4)
tests/qmltests/Launcher/tst_Launcher.qml (+0/-5)
To merge this branch: bzr merge lp://staging/~cimi/unity8/fix-1368778-2
Reviewer Review Type Date Requested Status
Michael Zanetti (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Albert Astals Cid (community) Needs Fixing
Review via email: mp+242942@code.staging.launchpad.net

Commit message

Remove dismiss timer in Launcher

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
 * Did you make sure that your branch does not contain spurious tags?
Yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
y

To post a comment you must log in.
lp://staging/~cimi/unity8/fix-1368778-2 updated
1452. By Andrea Cimitan

Add comment

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1451
http://jenkins.qa.ubuntu.com/job/unity8-ci/4984/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/379
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/161
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/149
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/149
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/341
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/379
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/379/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16282

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4984/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1452
http://jenkins.qa.ubuntu.com/job/unity8-ci/4986/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/382
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/163
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/151
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/151
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/344
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/382
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/382/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16287

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4986/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

FAIL! : qmltestrunner::Shell::test_tapUbuntuIconInLauncherOverAppSpread() Uncaught exception: Type error
   Loc: [/tmp/buildd/unity8-8.01+15.04.20141125.2bzr1453pkg0vivid163/tests/qmltests/tst_Shell.qml(750)]

review: Needs Fixing
lp://staging/~cimi/unity8/fix-1368778-2 updated
1453. By Andrea Cimitan

Comment out another piece

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1453
http://jenkins.qa.ubuntu.com/job/unity8-ci/4994/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/415
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/171
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/159
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/159
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/365
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/415
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/415/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16347

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4994/rebuild

review: Approve (continuous-integration)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

Instead of creating all that comments mess, can't we just add a property bool autohideEnabled at the top, and only start the timer if that property is true?

review: Needs Information
lp://staging/~cimi/unity8/fix-1368778-2 updated
1454. By Andrea Cimitan

With property

Revision history for this message
Michael Zanetti (mzanetti) wrote :

ok. change looks good to me now. It's working fine. I think the thing in the tests can be deleted. If something like this would be required again, the new way would be to set autohideEnabled to false.

review: Needs Fixing
lp://staging/~cimi/unity8/fix-1368778-2 updated
1455. By Andrea Cimitan

Removed piece in a test

Revision history for this message
Michael Zanetti (mzanetti) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

hmm... seems to be on a break

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches