Unity 8

Merge lp://staging/~cimi/unity8/elastic-not-close-spread into lp://staging/unity8

  1. elastic-not-close-spread
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 1462
Merged at revision: 1471
Proposed branch: lp://staging/~cimi/unity8/elastic-not-close-spread
Merge into: lp://staging/unity8
Diff against target: 55 lines (+16/-6)
2 files modified
qml/Stages/SpreadDelegate.qml (+8/-1)
tests/qmltests/Stages/tst_SpreadDelegate.qml (+8/-5)
To merge this branch: bzr merge lp://staging/~cimi/unity8/elastic-not-close-spread
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Albert Astals Cid (community) Approve
Review via email: mp+242949@code.staging.launchpad.net

Commit message

Different drag behaviour for not closable apps in spread

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No
 * Did you perform an exploratory manual test run of your code change and any related functionality?
yes
 * Did you make sure that your branch does not contain spurious tags?
Yes
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
n/a
 * If you changed the UI, has there been a design review?
tomorrow morning

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1460
http://jenkins.qa.ubuntu.com/job/unity8-ci/4985/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/381
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/162
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/150
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/150
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/343
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/381
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/381/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16286

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4985/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~cimi/unity8/elastic-not-close-spread updated
1461. By Andrea Cimitan

Tweaked limit as design requested

1462. By Andrea Cimitan

Fix test

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1461
http://jenkins.qa.ubuntu.com/job/unity8-ci/4988/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/393/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/165
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/153
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/153
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/352/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/393
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/393/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/16310

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4988/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes

 * Did CI run pass?
Flacky unlrelated autopilot

 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1462
http://jenkins.qa.ubuntu.com/job/unity8-ci/4989/
Executed test runs:
    ABORTED: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/394/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-vivid/166
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-amd64-ci/154
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-vivid-i386-ci/154
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/394
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/394/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/4989/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches