Merge lp://staging/~cimi/overlay-scrollbar/protect-846562 into lp://staging/overlay-scrollbar
Proposed by
Andrea Cimitan
| Status: | Merged |
|---|---|
| Approved by: | Ted Gould |
| Approved revision: | 344 |
| Merge reported by: | Andrea Cimitan |
| Merged at revision: | not available |
| Proposed branch: | lp://staging/~cimi/overlay-scrollbar/protect-846562 |
| Merge into: | lp://staging/overlay-scrollbar |
| Diff against target: |
19 lines (+6/-3) 1 file modified
os/os-scrollbar.c (+6/-3) |
| To merge this branch: | bzr merge lp://staging/~cimi/overlay-scrollbar/protect-846562 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Protect against 846562
To post a comment you must log in.
Revision history for this message
| Andrea Cimitan (cimi) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This is weird bug, I don't know if this is a correct fix for that, because the widget logically has to be realized.
In fact, on scrollbar unmap we hide the thumb. This function is called when the thumb receives a button press, so the scrollbar should not have received an unmap otherwise the click is not possible :-\ Opinions?