overlay-scrollbar

Merge lp://staging/~cimi/overlay-scrollbar/insensitive-state into lp://staging/overlay-scrollbar

  1. insensitive-state
  2. Merge into trunk
Proposed by Andrea Cimitan
Status: Merged
Approved by: Ted Gould
Approved revision: 295
Merged at revision: 295
Proposed branch: lp://staging/~cimi/overlay-scrollbar/insensitive-state
Merge into: lp://staging/overlay-scrollbar
Diff against target: 282 lines (+142/-32)
2 files modified
configure.ac (+1/-1)
os/os-scrollbar.c (+141/-31)
To merge this branch: bzr merge lp://staging/~cimi/overlay-scrollbar/insensitive-state
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email: mp+67927@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

On this line:

return gtk_widget_get_state_flags (GTK_WIDGET (scrollbar)) & GTK_STATE_FLAG_INSENSITIVE;

It would probably be better to do:

return gtk_widget_get_state_flags (GTK_WIDGET (scrollbar)) & GTK_STATE_FLAG_INSENSITIVE != 0;

So that the return value is a boolean proper. Shouldn't be an issue, but it's safer.

That's it, looks good.

review: Approve
lp://staging/~cimi/overlay-scrollbar/insensitive-state updated
296. By Andrea Cimitan

Fixes to is_insensitive and set_state_flags

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches