Merge lp://staging/~cimi/overlay-scrollbar/fix.868739-take_1bis into lp://staging/overlay-scrollbar
Proposed by
Andrea Cimitan
| Status: | Rejected |
|---|---|
| Rejected by: | Andrea Cimitan |
| Proposed branch: | lp://staging/~cimi/overlay-scrollbar/fix.868739-take_1bis |
| Merge into: | lp://staging/overlay-scrollbar |
| Diff against target: |
73 lines (+12/-24) 1 file modified
os/os-scrollbar.c (+12/-24) |
| To merge this branch: | bzr merge lp://staging/~cimi/overlay-scrollbar/fix.868739-take_1bis |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Andrea Cimitan | Disapprove | ||
| Ted Gould (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Enhanced approach to https:/
Stores the values only when showing the thumb for the first time. (Might fail if someone scrolls a scrolled window which contains the scrollbar while you're in the proximity area and you mapped the thumb)
To post a comment you must log in.
Revision history for this message
| Ted Gould (ted) | # |
review:
Approve
Unmerged revisions
- 313. By Andrea Cimitan
-
Fix 868739
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I disapprove this and will take the original lp:~cimi/ayatana-scrollbar/fix.868739-take_1
Why? Because I think it's faster to simply write the variables to memory rather than calling the external function (which will do multiple checks on the widget then for its mapped state) AND evaluating the value. Also, should be safer on the weird case mentioned