ubuntu-openstack-ci

Merge lp://staging/~chris.macnaughton/ubuntu-openstack-ci/gerrit-commit-message into lp://staging/ubuntu-openstack-ci

  1. gerrit-commit-message
  2. Merge into trunk
Proposed by Chris MacNaughton
Status: Merged
Merged at revision: 425
Proposed branch: lp://staging/~chris.macnaughton/ubuntu-openstack-ci/gerrit-commit-message
Merge into: lp://staging/ubuntu-openstack-ci
Diff against target: 16 lines (+5/-1)
1 file modified
run/job-parts/osci_openstack_common.sh (+5/-1)
To merge this branch: bzr merge lp://staging/~chris.macnaughton/ubuntu-openstack-ci/gerrit-commit-message
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+378222@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

LGTM, thanks for your work on this

review: Approve
Revision history for this message
Liam Young (gnuoy) wrote :

Actually the -z looks wrong

review: Needs Fixing
Revision history for this message
Liam Young (gnuoy) wrote :

Confirmed white space needed before '-z'

Revision history for this message
Liam Young (gnuoy) wrote :

Doesn't line 14 need a '\' too ?

lp://staging/~chris.macnaughton/ubuntu-openstack-ci/gerrit-commit-message updated
426. By Chris MacNaughton

Fix syntax issues

Revision history for this message
Liam Young (gnuoy) wrote :

Needs white space after "$GERRIT_CHANGE_COMMIT_MESSAGE" before the ']' on line 9

review: Needs Fixing
lp://staging/~chris.macnaughton/ubuntu-openstack-ci/gerrit-commit-message updated
427. By Chris MacNaughton

Fix another syntax issue

428. By Chris MacNaughton

Remove guard against impossible situation

We will not replace Zaza* dependencies in landed
changes, so we do not need to be able to parse out
the bits from the commit message to do the replacement

Revision history for this message
Liam Young (gnuoy) wrote :

LGTM, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches