Merge lp://staging/~chris.macnaughton/openstack-mojo-specs/upgrade-spec into lp://staging/~ost-maintainers/openstack-mojo-specs/openstack-mojo-specs-1802

Proposed by Chris MacNaughton
Status: Needs review
Proposed branch: lp://staging/~chris.macnaughton/openstack-mojo-specs/upgrade-spec
Merge into: lp://staging/~ost-maintainers/openstack-mojo-specs/openstack-mojo-specs-1802
Diff against target: 357 lines (+297/-3)
6 files modified
helper/bundles/ubuntu-lite.yaml (+5/-0)
helper/collect/collect-ubuntu-lite (+1/-0)
helper/scripts/upgrade_all_units.py (+13/-0)
helper/utils/mojo_utils.py (+261/-3)
specs/dev/series_upgrade_ubuntu_lite/SPEC_INFO.txt (+1/-0)
specs/dev/series_upgrade_ubuntu_lite/manifest (+16/-0)
To merge this branch: bzr merge lp://staging/~chris.macnaughton/openstack-mojo-specs/upgrade-spec
Reviewer Review Type Date Requested Status
David Ames (community) Needs Fixing
Review via email: mp+341397@code.staging.launchpad.net
To post a comment you must log in.
333. By Chris MacNaughton

rename upgrade script

Revision history for this message
David Ames (thedac) wrote :

I still need to do a full review but make lint fails with a number of lint problems.

review: Needs Fixing
Revision history for this message
David Ames (thedac) wrote :

Ok, so we have a lot of context in https://code.launchpad.net/~chris.macnaughton/openstack-mojo-specs/upgrade-spec/+merge/337646 which I would like to continue.

My recommendation is we merge the 18.02 branch without this change, abandon this MP and continue with the original MP which has several unaddressed comments.

334. By Chris MacNaughton

update to resolve lint issues and resolve discussions

- remove prints
- shift to use `juju run` where possible

Unmerged revisions

334. By Chris MacNaughton

update to resolve lint issues and resolve discussions

- remove prints
- shift to use `juju run` where possible

333. By Chris MacNaughton

rename upgrade script

332. By Chris MacNaughton

updating series upgrade spec

331. By Chris MacNaughton

update handlers to get units started correctly

330. By Chris MacNaughton

tidy a bit

329. By Chris MacNaughton

add helper to upgrade all units in a model

328. By Chris MacNaughton

starting framing upgrade spec

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches