Merge lp://staging/~chris.macnaughton/openstack-mojo-specs/ceph into lp://staging/~ost-maintainers/openstack-mojo-specs/mojo-openstack-specs-1709

Proposed by Chris MacNaughton
Status: Rejected
Rejected by: Ryan Beisner
Proposed branch: lp://staging/~chris.macnaughton/openstack-mojo-specs/ceph
Merge into: lp://staging/~ost-maintainers/openstack-mojo-specs/mojo-openstack-specs-1709
Diff against target: 90 lines (+7/-7)
7 files modified
specs/storage/ceph/base/icehouse/manifest (+1/-1)
specs/storage/ceph/base/kilo/manifest (+1/-1)
specs/storage/ceph/base/liberty/manifest (+1/-1)
specs/storage/ceph/base/mitaka/manifest (+1/-1)
specs/storage/ceph/base/newton/manifest (+1/-1)
specs/storage/ceph/base/ocata/manifest (+1/-1)
specs/storage/ceph/base/pike/manifest (+1/-1)
To merge this branch: bzr merge lp://staging/~chris.macnaughton/openstack-mojo-specs/ceph
Reviewer Review Type Date Requested Status
Andrew McLeod (community) Approve
OpenStack Charm Testing Maintainers Pending
Review via email: mp+330018@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Andrew McLeod (admcleod) wrote :

I can see that ceph-default.yaml does not exist in this repo, but ceph-base.yaml does, so I'm giving this a +1 - although more info would be useful as to how this name ended up being wrong?

review: Approve
Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :

I suspect that it was missed when the entire directory structure changed, including the file being renamed from ceph-default.yaml to ceph-base.yaml

Revision history for this message
Chris MacNaughton (chris.macnaughton) wrote :
Revision history for this message
Ryan Beisner (1chb1n) wrote :

Thanks for your patch, but this is already resolved in a separate commit.

http://bazaar.launchpad.net/~ost-maintainers/openstack-mojo-specs/mojo-openstack-specs-1709/revision/311

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches