Merge lp://staging/~chris.macnaughton/openstack-mojo-specs/add-pike into lp://staging/openstack-mojo-specs

Proposed by Chris MacNaughton
Status: Merged
Merged at revision: 312
Proposed branch: lp://staging/~chris.macnaughton/openstack-mojo-specs/add-pike
Merge into: lp://staging/openstack-mojo-specs
Diff against target: 95 lines (+31/-0)
1 file modified
helper/utils/os_versions.py (+31/-0)
To merge this branch: bzr merge lp://staging/~chris.macnaughton/openstack-mojo-specs/add-pike
Reviewer Review Type Date Requested Status
Corey Bryant Approve
Review via email: mp+333257@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Corey Bryant (corey.bryant) wrote :

I'm not overly familiar with this file but I think you want to cross-check this with charmhelpers/contrib/openstack/utils.py.

It seems like the mojo specs should sync and use the charm-helper's code but that may be for a different day.

313. By Chris MacNaughton

update to match what charm-helpers has

Revision history for this message
Corey Bryant (corey.bryant) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches