Mojo: Continuous Delivery for Juju

Merge lp://staging/~chris.macnaughton/mojo/py3003 into lp://staging/~ost-maintainers/mojo/py3

  1. py3003
  2. Merge into py3
Proposed by Chris MacNaughton
Status: Needs review
Proposed branch: lp://staging/~chris.macnaughton/mojo/py3003
Merge into: lp://staging/~ost-maintainers/mojo/py3
Diff against target: 217 lines (+56/-13)
5 files modified
mojo/cli.py (+1/-1)
mojo/contain.py (+26/-6)
mojo/juju/debuglogs.py (+7/-1)
mojo/juju/status.py (+9/-2)
mojo/phase.py (+13/-3)
To merge this branch: bzr merge lp://staging/~chris.macnaughton/mojo/py3003
Reviewer Review Type Date Requested Status
OpenStack Charm Testing Maintainers Pending
Review via email: mp+337159@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~chris.macnaughton/mojo/py3003 updated
470. By Chris MacNaughton

cleanup error output

Revision history for this message
Alexandre Gomes (alejdg) wrote :

+1

Reply
Revision history for this message
Colin Watson (cjwatson) wrote :

Any reason not to use universal_newlines=True on subprocess.check_output calls that are supposed to emit text instead? As long as unicode output can be tolerated in the Python 2 case, this is generally a simpler way to do this.

Reply

Unmerged revisions

470. By Chris MacNaughton

cleanup error output

469. By Chris MacNaughton

add more decode calls

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches