Charm Helpers

Merge lp://staging/~chris.macnaughton/charm-helpers/default-rbd-features into lp://staging/charm-helpers

  1. default-rbd-features
  2. Merge into devel
Proposed by Chris MacNaughton
Status: Merged
Merged at revision: 765
Proposed branch: lp://staging/~chris.macnaughton/charm-helpers/default-rbd-features
Merge into: lp://staging/charm-helpers
Diff against target: 34 lines (+6/-1)
2 files modified
charmhelpers/contrib/openstack/context.py (+2/-0)
charmhelpers/contrib/openstack/templates/ceph.conf (+4/-1)
To merge this branch: bzr merge lp://staging/~chris.macnaughton/charm-helpers/default-rbd-features
Reviewer Review Type Date Requested Status
David Ames (community) Approve
Pen Gale Pending
Chris MacNaughton Pending
Review via email: mp+327518@code.staging.launchpad.net

This proposal supersedes a proposal from 2017-06-29.

To post a comment you must log in.
Revision history for this message
Pen Gale (pengale) wrote : Posted in a previous version of this proposal

This is what I expected, based on conversations in the Openstack team sync. +1

review: Approve
Revision history for this message
Chris MacNaughton (chris.macnaughton) : Posted in a previous version of this proposal
review: Needs Fixing
Revision history for this message
Chris MacNaughton (chris.macnaughton) : Posted in a previous version of this proposal
review: Needs Resubmitting
Revision history for this message
David Ames (thedac) wrote :

Sounds like the testing went well.

Looks good. Merging.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches