Merge lp://staging/~chris.gagnon/qa-coverage-dashboard/only-get-last-build-from-jenkins into lp://staging/qa-coverage-dashboard
Proposed by
Chris Gagnon
| Status: | Merged |
|---|---|
| Merged at revision: | 773 |
| Proposed branch: | lp://staging/~chris.gagnon/qa-coverage-dashboard/only-get-last-build-from-jenkins |
| Merge into: | lp://staging/qa-coverage-dashboard |
| Diff against target: |
299 lines (+146/-49) 4 files modified
gaps/management/commands/c2dconfigutils/cu2dOutputCi.py (+10/-6) gaps/management/commands/jenkins_pull_coverage.py (+14/-1) gaps/tests/test_jenkins_pull_coverage.py (+113/-38) gaps/util/add.py (+9/-4) |
| To merge this branch: | bzr merge lp://staging/~chris.gagnon/qa-coverage-dashboard/only-get-last-build-from-jenkins |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Allan LeSage (community) | Approve | ||
| gaps | Pending | ||
|
Review via email:
|
|||
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
I like the tests, they're good. I personally like when assertions go like this: assertEqual(42, my_var) , but apparently there's no consensus on that. A couple of things:
* Can we not test those integers as strings?
* For ll. 68-71, I think you can not do the conditional and just pass through the var.
Otherwise looks good.