Aeroo Reports

Merge lp://staging/~chris-ormaza/aeroo/openerp6 into lp://staging/aeroo/openerp6

openerp6
Merge into openerp6

Proposed by Christopher Ormaza - (Ecuadorenlinea.net) on 2011-12-30

Status:	Needs review
Proposed branch:	lp://staging/~chris-ormaza/aeroo/openerp6
Merge into:	lp://staging/aeroo/openerp6
Diff against target:	179 lines (+60/-12) 1 file modified report_aeroo/currency_to_text.py (+60/-12)
To merge this branch:	bzr merge lp://staging/~chris-ormaza/aeroo/openerp6
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
sraps (Alistek)		2011-12-30	Needs Information on 2012-01-02
Review via email: mp+87157@code.staging.launchpad.net

Description of the change

Add Spanish Support

Revision history for this message

sraps (Alistek) (erpsraps) wrote on 2012-01-02:

Hi, Christopher!

First of all - thanks for the work!
We will implement your localization in Aeroo, still some remarks:
* Do you think that it would be good to use just "es" in supported_language variable, preferably express them in form equal to OpenERP's language list (lv_LV, en_US,...). Even though there would be some dummy language codes, still user would not need to do a conversion on template. So templates would become generic even for languages not directly developed to.

* we will not include this inside Aeroo Reports 1.0, but rather port it to the trunk version with completely redesigned this function. Although technically function in this form performed fair enough, it already has become unmanageable by increasing number of languages present.

Please provide your answer on the es/es_ES question...

BR
Kaspars

review: Needs Information

Revision history for this message

Christopher Ormaza - (Ecuadorenlinea.net) (chris-ormaza) wrote on 2012-01-03:

Hi, Kaspars!

I think the code should have 'es_ES' too, really I just put 'es' because I thought it would be more generic, but if you are agree, I put the 'es_ES' in the code and re-merge the branch, I don't have problem with this, and thanks for your revision and add for this fantastic work

Regards
Christopher

> Hi, Christopher!
>
> First of all - thanks for the work!
> We will implement your localization in Aeroo, still some remarks:
> * Do you think that it would be good to use just "es" in supported_language
> variable, preferably express them in form equal to OpenERP's language list
> (lv_LV, en_US,...). Even though there would be some dummy language codes,
> still user would not need to do a conversion on template. So templates would
> become generic even for languages not directly developed to.
>
> * we will not include this inside Aeroo Reports 1.0, but rather port it to the
> trunk version with completely redesigned this function. Although technically
> function in this form performed fair enough, it already has become
> unmanageable by increasing number of languages present.
>
> Please provide your answer on the es/es_ES question...
>
> BR
> Kaspars