lp://staging/koha/3.8.x

Branch merges

This import branch has no branches proposed for merge into it.

No branches dependent on this one.

Related source package recipes

1 recipe using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

13283. By Owen Leonard on 2013-03-17

Bug 9765 - Remove unused include file: budgetperiods-admin.inc

budgetperiods-admin.inc doesn't appear to be used anywhere in Koha. This
patch removes it.

To test, confirm that a search for references to budgetperiods-admin.inc
returns no results.

Signed-off-by: Kyle M Hall <email address hidden>
Signed-off-by: Jonathan Druart <email address hidden>
Signed-off-by: Jared Camins-Esakov <email address hidden>
Signed-off-by: Chris Cormack <email address hidden>

13282. By Owen Leonard on 2013-03-17

Bug 7596 - System prefs editor JS contains untranslatable English string

There is one stray instance of an untranslatable string in
preferences.js. This patch replaces it with a variable which is now
defined in the preferences template.

To test, open the system preferences editor and change any setting. You
should see the usual "Saved preference <preference name>" message.

To test that error strings are now translatable, run "perl translate
update <lang>" from misc/translator, then check if the affected strings shows
up in the po file.

Signed-off-by: Liz Rea <email address hidden>
Tested both, all ok.

Signed-off-by: Jonathan Druart <email address hidden>
Signed-off-by: Jared Camins-Esakov <email address hidden>
Signed-off-by: Chris Cormack <email address hidden>

13281. By Mathieu Saby <email address hidden> on 2013-03-17

Bug 4266: Hide Encumbrance and Expenditure in aqbudgets.tt

Encumbrance and Expenditure fields are not taken into account by Koha,
but the data are saved in database.
This patch hide these fields in aqbudgets.tt
To test : check if the 2 fields are hidden when creating a new fund.

Signed-off-by: Owen Leonard <email address hidden>

This could certainly be done in a few different ways both with CSS and
JS, but this is a simple change and can be easily overridden:

$("#budget_encumb,#budget_expend").closest("li").show();

Signed-off-by: Jonathan Druart <email address hidden>
Signed-off-by: Jared Camins-Esakov <email address hidden>
Signed-off-by: Chris Cormack <email address hidden>

13280. By Liz Rea <email address hidden> on 2013-03-16

bug 9784: add koha-shell to the koha-common man page

To test:

Build a package from a git checkout with this patch included
once installed, run man koha-common - koha-shell should appear near the bottom.

Signed-off-by: Robin Sheat <email address hidden>
Signed-off-by: Galen Charlton <email address hidden>
Signed-off-by: Jared Camins-Esakov <email address hidden>
Signed-off-by: Chris Cormack <email address hidden>

13279. By Owen Leonard on 2013-03-16

Bug 9695 - Use alphabet system preference on page used to browse patrons for patron card batches

When adding patrons to a batch for creating patron cards, the template
shows alphabet links for browsing all patrons. This patch converts the
hard-coded alphabet links to use the new alphabet system preference.

To test, go to the patron card creator and create a new batch. Click
"Add items" to pop up the window for browsing for patrons to add to the
batch. You should see a working array of alphabet letters which link to
patron search results.

Signed-off-by: David Cook <email address hidden>

The patch adds consistency to the interface and works as described.
Signed-off-by: Jonathan Druarth <email address hidden>
Signed-off-by: Jared Camins-Esakov <email address hidden>

Signed-off-by: Chris Cormack <email address hidden>

13278. By Chris Cormack on 2013-03-16

Bumping db version

13277. By Kyle M Hall <email address hidden> on 2013-03-16

Bug 9207 - Improve z39.50 speed slowdowns for sites with many records

Signed-off-by: Marcel de Rooy <email address hidden>
Signed-off-by: Jared Camins-Esakov <email address hidden>

Conflicts:
 installer/data/mysql/updatedatabase.pl

Signed-off-by: Chris Cormack <email address hidden>

13276. By Liz Rea <email address hidden> on 2013-03-16

Bug 8054 - double clicking can cause duplicate payments/fines

Uses preventDoubleForSubmit() to prevent double form submissions in the fines module.

To test:

Create a manual invoice/fine
Create some manual fines, click save like mad - you should get only one fine (without, you will get several if you click madly enough)

Click Pay fines
Pay some fines, clicking save like mad on each. You should only get one payment. (without, you will get several payments)

Create a manual credit
Create a credit, click save like mad. You should only get one credit. (without you will get several if you click madly enough)

Signed-off-by: Kyle M Hall <email address hidden>
Signed-off-by: Marcel de Rooy <email address hidden>
Signed-off-by: Jared Camins-Esakov <email address hidden>
Signed-off-by: Chris Cormack <email address hidden>

13275. By Fridolyn SOMERS <email address hidden> on 2013-03-16

Bug 9377 - itemtype in duplicate biblio search

In C4::Search::FindDuplicate, when biblio has no ISBN, the duplicate search adds :
$query .= " and itemtype=$result->{itemtype}".
This is wrong when itemtype is defined in items.

This patch simply removes the itemtype from dublicate search.

Test plan :
- Go to a biblio details page
- Click on "Edit as new (duplicate)"
- If ISBN is defined, remove it
- Click on save
=> a duplicate is detected
- Change biblio item type and save
=> a duplicate is detected
Signed-off-by: Marcel de Rooy <email address hidden>
Signed-off-by: Jared Camins-Esakov <email address hidden>

Signed-off-by: Chris Cormack <email address hidden>

13274. By David Cook on 2013-03-11

Bug 9586 - Remove $ENV{DEBUG} info from Member Template

Currently, if $ENV{DEBUG} is set (for example to 1), the debug level
will be printed on the Add/Edit Patron pages (memberentrygen.tt) in the
form of: "Debug is on (level 1)".

While many if not most folks might not set $ENV{DEBUG} on a production
system, there is no reason to have this information printing on the
member template(s).

No where else in Koha is there a template that prints $ENV{DEBUG}
information, with the exception of calendar.inc, although that doesn't
activate until at least debug level 2 or 5, so it might be worth holding
on to. It is certainly more complicated than simply printing the debug
level. I don't do development on the calendars, so I'm not going to
address that one.

Signed-off-by: Kyle M Hall <email address hidden>
Signed-off-by: Elliott Davis <email address hidden>
Signed-off-by: Jared Camins-Esakov <email address hidden>
Signed-off-by: Chris Cormack <email address hidden>