Merge lp://staging/~chasedouglas/geis/fix-double-free into lp://staging/geis
Proposed by
Chase Douglas
| Status: | Merged |
|---|---|
| Merged at revision: | 219 |
| Proposed branch: | lp://staging/~chasedouglas/geis/fix-double-free |
| Merge into: | lp://staging/geis |
| Prerequisite: | lp://staging/~chasedouglas/geis/fix-system-tap |
| Diff against target: |
11 lines (+0/-1) 1 file modified
libutouch-geis/geis_v1.c (+0/-1) |
| To merge this branch: | bzr merge lp://staging/~chasedouglas/geis/fix-double-free |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stephen M. Webb (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
There is a double free when closing a geis v1 instance. The filter
deletion attempts to delete the backend token. The geis v2 instance also
attempts to delete the backend token. It seems to me that the filter
should be deleted by the geis v2 deletion, so I removed the filter
deletion.
I don't know that this is the best way to fix this, but it keeps the test
case from crashing. We need to do more valgrind profiling :(.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Yes, there's a longstanding issue with the refcounting in filters (mostly a confusion). The rule that works is if you add the filter to a subscription, do not explicitly delete it.