Geis

Merge lp://staging/~chasedouglas/geis/fix-deltas into lp://staging/geis

  1. fix-deltas
  2. Merge into trunk
Proposed by Chase Douglas
Status: Merged
Merged at revision: 255
Proposed branch: lp://staging/~chasedouglas/geis/fix-deltas
Merge into: lp://staging/geis
Prerequisite: lp://staging/~chasedouglas/geis/delta-test
Diff against target: 109 lines (+43/-5)
1 file modified
libutouch-geis/backend/grail/geis_grail_backend.c (+43/-5)
To merge this branch: bzr merge lp://staging/~chasedouglas/geis/fix-deltas
Reviewer Review Type Date Requested Status
Stephen M. Webb (community) Approve
Chase Douglas (community) Needs Resubmitting
Review via email: mp+102776@code.staging.launchpad.net

Description of the change

Fix delta calculation when synchronous events are not enabled.

To post a comment you must log in.
Revision history for this message
Stephen M. Webb (bregma) wrote :

Should the radius and angle really be reset to zero when the number of touches change? That doesn't make a lot of sense to me from a functional point of view.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

I merely copied and pasted the radius and angle bits. After thinking some more, the angle should be reset to 0 (it's inherently a relative value), and the radius should be reset to 1 as it represents the ratio of the current radius to the original radius.

I'll fix this up.

lp://staging/~chasedouglas/geis/fix-deltas updated
256. By Chase Douglas

Calculate radius deltas as a ratio from previous geis event

The radius values are scale factors from the geis begin event, so the
deltas should be scale factors from the previous geis event too.

257. By Chase Douglas

Merged delta-test into fix-deltas.

Revision history for this message
Chase Douglas (chasedouglas) wrote :

I have fixed the radius deltas now. Please review.

review: Needs Resubmitting
Revision history for this message
Stephen M. Webb (bregma) wrote :

OK.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches