Merge lp://staging/~chasedouglas/frame/Weffc++ into lp://staging/frame

Proposed by Chase Douglas
Status: Merged
Merged at revision: 76
Proposed branch: lp://staging/~chasedouglas/frame/Weffc++
Merge into: lp://staging/frame
Diff against target: 266 lines (+59/-17)
16 files modified
src/v2/axis.h (+3/-1)
src/v2/device.h (+4/-2)
src/v2/event.h (+3/-1)
src/v2/frame.cpp (+3/-1)
src/v2/frame.h (+4/-2)
src/v2/handle.cpp (+1/-1)
src/v2/handle.h (+3/-1)
src/v2/property.h (+4/-2)
src/v2/touch.cpp (+2/-1)
src/v2/touch.h (+3/-1)
src/v2/x11/device_x11.cpp (+3/-1)
src/v2/x11/handle_x11.cpp (+4/-1)
src/v2/x11/window_x11.cpp (+4/-1)
test/x11/device.cpp (+3/-0)
test/x11/fixture.h (+5/-0)
test/x11/recording.cpp (+10/-1)
To merge this branch: bzr merge lp://staging/~chasedouglas/frame/Weffc++
Reviewer Review Type Date Requested Status
Thomas Voß (community) Approve
Jussi Pakkanen (community) Approve
Review via email: mp+98866@code.staging.launchpad.net

Description of the change

Fix all issues found with -Weffc++.

See commit comment for details about the remaining issue outside of
utouch-frame.

To post a comment you must log in.
Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Ok.

review: Approve
Revision history for this message
Thomas Voß (thomas-voss) wrote :

LGTM, builds fine, all tests pass (Jenkins staging).

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches