powerd

Merge lp://staging/~charlesk/powerd/lp-1370791-add-brightness-property into lp://staging/powerd

  1. lp-1370791-add-brightness-property
  2. Merge into trunk
Proposed by Charles Kerr
Status: Merged
Approved by: Alejandro J. Cura
Approved revision: 166
Merged at revision: 165
Proposed branch: lp://staging/~charlesk/powerd/lp-1370791-add-brightness-property
Merge into: lp://staging/powerd
Diff against target: 83 lines (+32/-1)
4 files modified
data/com.canonical.powerd.xml (+4/-0)
src/backlight.c (+3/-1)
src/powerd-internal.h (+1/-0)
src/powerd-object.c (+24/-0)
To merge this branch: bzr merge lp://staging/~charlesk/powerd/lp-1370791-add-brightness-property
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ricardo Salveti (community) code review Approve
Alejandro J. Cura (community) Approve
Review via email: mp+259678@code.staging.launchpad.net

Commit message

publish brightness changes on the bus.

Description of the change

Make an org.dbus.freedesktop.Property for brightness so that clients can watch to see when powerd adjusts brightness automatically.

Required for https://bugs.launchpad.net/ubuntu/+source/ubuntu-system-settings/+bug/1370791

To post a comment you must log in.
Revision history for this message
Alejandro J. Cura (alecu) wrote :

Code looks good. Tested on mako with wily, works great.

review: Approve
Revision history for this message
Ricardo Salveti (rsalveti) wrote :

Code looks good, just waiting for the silo for proper testing.

review: Approve (code review)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:166
http://jenkins.qa.ubuntu.com/job/powerd-ci/178/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/powerd-vivid-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/powerd-vivid-armhf-ci/6/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/powerd-ci/178/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches