Pay Service

Merge lp://staging/~charlesk/pay-service/silence-prices-warning into lp://staging/pay-service/15.04

  1. silence-prices-warning
  2. Merge into trunk.15.04
Proposed by Charles Kerr
Status: Rejected
Rejected by: dobey
Proposed branch: lp://staging/~charlesk/pay-service/silence-prices-warning
Merge into: lp://staging/pay-service/15.04
Diff against target: 36 lines (+12/-3)
2 files modified
libpay/internal/package.cpp (+8/-3)
tests/com_canonical_pay_store.py (+4/-0)
To merge this branch: bzr merge lp://staging/~charlesk/pay-service/silence-prices-warning
Reviewer Review Type Date Requested Status
dobey (community) Needs Resubmitting
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+278167@code.staging.launchpad.net

Commit message

in libpay's create_pay_item_from_variant(), don't warn on some unhandled properties, e.g. 'prices'

Description of the change

in libpay's create_pay_item_from_variant(), don't warn on some unhandled properties, e.g. 'prices'

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:54
http://jenkins.qa.ubuntu.com/job/pay-service-15.04-ci/97/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/pay-service-15.04-vivid-amd64-ci/97/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/pay-service-15.04-vivid-armhf-ci/97/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/pay-service-15.04-ci/97/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
dobey (dobey) wrote :

This needs to be re-created against lp:pay-service as we are set up for dual landing now, so landing into the 15.04 branch only shouldn't be done.

review: Needs Resubmitting

Unmerged revisions

54. By Charles Kerr

in libpay's create_pay_item_from_variant(), don't warn on some properties, e.g. 'prices'

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: