libindicator

Merge lp://staging/~charlesk/libindicator/indicator-loader3-show-all-profiles into lp://staging/libindicator/13.10

  1. indicator-loader3-show-all-profiles
  2. Merge into trunk.13.10
Proposed by Charles Kerr
Status: Merged
Approved by: Ted Gould
Approved revision: 511
Merged at revision: 507
Proposed branch: lp://staging/~charlesk/libindicator/indicator-loader3-show-all-profiles
Merge into: lp://staging/libindicator/13.10
Diff against target: 561 lines (+309/-212)
1 file modified
tools/indicator-loader.c (+309/-212)
To merge this branch: bzr merge lp://staging/~charlesk/libindicator/indicator-loader3-show-all-profiles
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+177088@code.staging.launchpad.net

Description of the change

in indicator-loader3, if we're looking at an ng-style indicator, show all of its profiles instead of just one.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:508
http://jenkins.qa.ubuntu.com/job/libindicator-ci/34/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/21
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/20

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/34/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:509
http://jenkins.qa.ubuntu.com/job/libindicator-ci/35/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/22
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/21

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/35/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:510
http://jenkins.qa.ubuntu.com/job/libindicator-ci/36/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/23
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/22

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/36/rebuild

review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:511
http://jenkins.qa.ubuntu.com/job/libindicator-ci/37/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-amd64-ci/24
    SUCCESS: http://jenkins.qa.ubuntu.com/job/libindicator-saucy-armhf-ci/23

Click here to trigger a rebuild:
http://s-jenkins:8080/job/libindicator-ci/37/rebuild

review: Approve (continuous-integration)
Revision history for this message
Ted Gould (ted) wrote :

In general, there's nothing wrong per se. A lot of code reformatting that probably should be in a different MR. I'm also really confused on why there's a grid of menubars and not just one menu bar with a lot of items.

review: Needs Information
Revision history for this message
Charles Kerr (charlesk) wrote :

wrt the menubars and grids, it's because each row is a different profile -- the label to the left of the row's menubar gives the name of the profile.

Revision history for this message
Ted Gould (ted) wrote :

Ah, I see now.

  review approve
  status approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches