libindicate

Merge lp://staging/~charlesk/libindicate/lp-957611 into lp://staging/libindicate/0.7

  1. lp-957611
  2. Merge into trunk.0.7
Proposed by Charles Kerr
Status: Merged
Approved by: Charles Kerr
Approved revision: 451
Merge reported by: Charles Kerr
Merged at revision: not available
Proposed branch: lp://staging/~charlesk/libindicate/lp-957611
Merge into: lp://staging/libindicate/0.7
Diff against target: 130 lines (+74/-46)
1 file modified
libindicate/listener.c (+74/-46)
To merge this branch: bzr merge lp://staging/~charlesk/libindicate/lp-957611
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
Review via email: mp+98056@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Charles Kerr (charlesk) wrote :

Before:

  if (error) {
    g_warning ("error!");
    goto cleanup;
  }
  GVariant foo = bar; /* Coverity is unhappy about foo + goto */
  yadda;
cleanup:
   ...

After:

  if (error) {
    g_warning ("error!");
  } else {
    GVariant foo = bar;
    yadda;
  }
  ...

Revision history for this message
Lars Karlitski (larsu) wrote :

Has nothing to do with the intention of the patch, but 'value' is still leaked (line 56 in the diff).

review: Needs Fixing
Revision history for this message
Charles Kerr (charlesk) wrote :

Thank you lars!

lp://staging/~charlesk/libindicate/lp-957611 updated
451. By Charles Kerr

fix pre-existing GVariant leak that my patch didn't fix. reported by larsu

Revision history for this message
Lars Karlitski (larsu) wrote :

Excellent, thank you Charles!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches