DBus Menu

Merge lp://staging/~charlesk/libdbusmenu/disconnect-menuitem-shown into lp://staging/libdbusmenu/0.6

Proposed by Charles Kerr on 2012-04-10

Status:	Merged
Approved by:	Ted Gould on 2012-04-11
Approved revision:	409
Merged at revision:	409
Proposed branch:	lp://staging/~charlesk/libdbusmenu/disconnect-menuitem-shown
Merge into:	lp://staging/libdbusmenu/0.6
Diff against target:	10 lines (+1/-0) 1 file modified libdbusmenu-glib/server.c (+1/-0)
To merge this branch:	bzr merge lp://staging/~charlesk/libdbusmenu/disconnect-menuitem-shown
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ted Gould (community)		2012-04-10	Approve on 2012-04-11
Review via email: mp+101454@code.staging.launchpad.net

In menuitem_signals_remove(), disconnect the DBUSMENU_MENUITEM_SIGNAL_SHOW_TO_USER event that we connected to in menuitem_signals_create().

It looks like this non-disconnected signal goes all the way back to July 2010 <http://bazaar.launchpad.net/~dbusmenu-team/dbusmenu/trunk.0.6/revision/139#libdbusmenu-glib/server.c> so I'd like ted's eyes on this to confirm there's not some nuance that I'm missing...