Merge lp://staging/~charlesk/indicator-transfer/fix-flint-and-clang-warnings into lp://staging/indicator-transfer/14.10
Proposed by
Charles Kerr
| Status: | Superseded |
|---|---|
| Proposed branch: | lp://staging/~charlesk/indicator-transfer/fix-flint-and-clang-warnings |
| Merge into: | lp://staging/indicator-transfer/14.10 |
| Diff against target: |
168 lines (+26/-20) 5 files modified
include/transfer/dbus-shared.h (+4/-0) include/transfer/world-dbus.h (+1/-1) src/world-dbus.cpp (+4/-11) tests/glib-fixture.h (+9/-0) tests/test-controller.cpp (+8/-8) |
| To merge this branch: | bzr merge lp://staging/~charlesk/indicator-transfer/fix-flint-and-clang-warnings |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
This proposal has been superseded by a proposal from 2014-11-05.
Commit message
Fixes warnings reported by flint++ and clang.
Description of the change
Fixes warnings reported by flint++ and clang.
No feature changes or end-user-visible changes.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| Ted Gould (ted) | # |
review:
Approve
Unmerged revisions
- 31. By Charles Kerr
-
fix type mismatch warnings (e.g., comparison of signed and unsigned)
- 30. By Charles Kerr
-
add a public virtual destrcutor to GlibFixture to fix flint++ warning
- 29. By Charles Kerr
-
add 'explicit' to single-argument constructor to fix flint++ warning
- 28. By Charles Kerr
-
fix include guard warnings reported by flint++
- 27. By Charles Kerr
-
use std::make_shared to silence flint++ warnings
- 26. By Charles Kerr
-
silence dead store warnings from scan-build
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
PASSED: Continuous integration, rev:31
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://