Merge lp://staging/~charlesk/indicator-sound/lp-1432446-use-bus-watcher-for-notifications into lp://staging/indicator-sound/15.10

Proposed by Charles Kerr
Status: Merged
Approved by: dobey
Approved revision: 493
Merged at revision: 495
Proposed branch: lp://staging/~charlesk/indicator-sound/lp-1432446-use-bus-watcher-for-notifications
Merge into: lp://staging/indicator-sound/15.10
Diff against target: 34 lines (+4/-13)
1 file modified
src/service.vala (+4/-13)
To merge this branch: bzr merge lp://staging/~charlesk/indicator-sound/lp-1432446-use-bus-watcher-for-notifications
Reviewer Review Type Date Requested Status
dobey (community) Approve
Review via email: mp+258300@code.staging.launchpad.net

Commit message

Use the BusWatcher to look for org.freedesktop.Notifications ownership changes on the bus.

Description of the change

Use BusWatcher, rather than a GDBusProxy, to watch for org.freedesktop.Notifications' owner to change. BusWatcher already handles bus errors gracefully, and as a bonus the resulting service code is slightly simpler.

This crash is happening when there are bigger problems on the system, evidenced by the ticket's description of a blank white screen before this crash shows up. i-sound isn't much use without a working session bus, but at least we can stop it from generating redundant bug reports.

Sibling 15.04 MP: https://code.launchpad.net/~charlesk/indicator-sound/lp-1432446-use-bus-watcher-for-notifications/+merge/256861

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches