Merge lp://staging/~charlesk/indicator-sound/lp-1244010 into lp://staging/indicator-sound/14.04

Proposed by Charles Kerr
Status: Merged
Approved by: Lars Karlitski
Approved revision: no longer in the source branch.
Merged at revision: 392
Proposed branch: lp://staging/~charlesk/indicator-sound/lp-1244010
Merge into: lp://staging/indicator-sound/14.04
Diff against target: 50 lines (+18/-1)
1 file modified
src/volume-control.vala (+18/-1)
To merge this branch: bzr merge lp://staging/~charlesk/indicator-sound/lp-1244010
Reviewer Review Type Date Requested Status
Lars Karlitski (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+192453@code.staging.launchpad.net

Commit message

When we can't connect to pulse, wait a moment before retrying.

Description of the change

When we can't connect to pulse, wait a moment before retrying.

Lars, I've confirmed that this fixes the stack smashing loop, but I'm unsure if this is The Right Thing. Is two seconds a good interval?

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Lars Karlitski (larsu) wrote :

Hm, I'm unsure if I like this. The original bug looked like an issue in pulse. But I guess not spinning like crazy when pulse crashes repeatedly is a good idea.

Thanks for the fix!

review: Approve
392. By Charles Kerr

When we can't connect to pulse, wait a moment before retrying. Fixes: https://bugs.launchpad.net/bugs/1244010.

Approved by Lars Uebernickel, PS Jenkins bot.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches