Merge lp://staging/~charlesk/indicator-power/lp-1416096-publish-primary-device-state-on-bus-15.04 into lp://staging/indicator-power/15.04

Proposed by Charles Kerr
Status: Merged
Approved by: Ken VanDine
Approved revision: 277
Merged at revision: 276
Proposed branch: lp://staging/~charlesk/indicator-power/lp-1416096-publish-primary-device-state-on-bus-15.04
Merge into: lp://staging/indicator-power/15.04
Diff against target: 129 lines (+80/-7)
1 file modified
src/service.c (+80/-7)
To merge this branch: bzr merge lp://staging/~charlesk/indicator-power/lp-1416096-publish-primary-device-state-on-bus-15.04
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Ken VanDine Approve
Ted Gould (community) Approve
Review via email: mp+248145@code.staging.launchpad.net

Commit message

Publish the primary device's state for on the bus.

Description of the change

Publish the primary device's state on the bus for the benefit of u-s-s.

Published as a string, eg "charging", "discharging", "empty", "full", "unknown". In the simple case of a device with a single battery, that battery's state is used. In more complex cases, the state of a virtual aggregated battery will be used as described in <https://wiki.ubuntu.com/Power#Handling_multiple_batteries>.

To post a comment you must log in.
277. By Charles Kerr

in the new device-state action state, use the string 'unknown' if no primary device is found.

Revision history for this message
Ted Gould (ted) wrote :

Cool, thanks for the "unknown" fix. Looks good.

review: Approve
Revision history for this message
Ken VanDine (ken-vandine) wrote :

looks good and works great. Perfectly solves my use case!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches